build: define the verify:dist task the release script already calls - #3523
Merged
Conversation
`scripts/release.ts` runs `deno task verify:dist` whenever `--no-build` is
not passed:
// 3. Verify distributable artifacts locally (CI will rebuild on publish)
if (!args["no-build"]) {
await runCommand(["deno", "task", "verify:dist"]);
}
No such task existed. Running it printed "Task not found: verify:dist"
followed by the task list, so any release cut without `--no-build` failed
at that step.
Together with #3505, which fixed `deno task test` dying on an orphaned
`#dnt` import, this is why recent releases were all cut as
`--no-test --no-build`: both of the release script's own gates were
unrunnable, for two unrelated reasons.
Defined as the two tasks the script's own comment names -- binary and npm
package. Verified by running it end to end on this branch: exit 0, both
artifacts produced. Defining a task that does not work would only move the
breakage, so it was run before being proposed.
Closes veryfront-issue-inbox#435.
kojiwakayama
enabled auto-merge
August 10, 2026 03:54
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Deno task configuration adds ChangesDistribution verification
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes veryfront-issue-inbox#435.
Problem
scripts/release.tsrunsdeno task verify:distwhenever--no-buildis not passed:No such task existed. Running it printed
Task not found: verify:distfollowed by the task list, so any release cut without--no-buildfailed at that step.Together with #3505 — which fixed
deno task testdying on an orphaned#dntimport since #3212 — this is why recent releases were all cut as--no-test --no-build: both of the release script's own gates were unrunnable, for two unrelated reasons. With both fixed, releases can run their own gates again.Fix
Defined as the two tasks the script's own comment names — binary and npm package:
Verified before proposing
Ran end to end on this branch:
Both artifacts produced, and no build output leaks into git (
git statusshows onlydeno.json). Defining a task that does not work would only relocate the breakage, so it was executed rather than assumed.Note on cost
It is not free —
verify:distcompiles the binary and builds the npm package locally, so an ungateddeno task releasebecomes substantially slower. That is presumably part of why the skip flags became habitual. If that tradeoff is unwanted, the alternative is to drop the call fromrelease.tsrather than leave it referencing a task that does not exist.Summary by CodeRabbit